bakaid commented on a change in pull request #635: MINIFICPP-819 - OPC Unified
Architecture Support
URL: https://github.com/apache/nifi-minifi-cpp/pull/635#discussion_r329553072
##########
File path: libminifi/include/Exception.h
##########
@@ -41,12 +41,13 @@ enum ExceptionType {
SITE2SITE_EXCEPTION,
GENERAL_EXCEPTION,
REGEX_EXCEPTION,
+ OPC_EXCEPTION,
Review comment:
Why can't PROCESSOR_EXCEPTION be used instead of this? As far as I can see
you throw this type of exception depending on the result of our operations
(utils::StringUtils::StringToBool, not even on the results of operations of the
third party OPC library.
I don't object against adding new exception types, but if we add this we
might add different exceptions for all extensions and I don't really see the
value in that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
