bakaid commented on a change in pull request #655: MINIFICPP-1049 - Fix make docker URL: https://github.com/apache/nifi-minifi-cpp/pull/655#discussion_r329738528
########## File path: docker/DockerBuild.sh ########## @@ -31,12 +31,13 @@ echo "CMake Source Directory: $CMAKE_SOURCE_DIR" echo "MiNiFi Package: $MINIFI_SOURCE_CODE" # Copy the MiNiFi source tree to the Docker working directory before building +rm -rf $CMAKE_SOURCE_DIR/docker/minificppsource Review comment: Excluding a path will not delete it in the target, even though we have the --delete flag said (this is the proper behaviour I think). However, this masked the error, because if you have already had the cmake directory copied, it left it as it was, just didn't update it, and the build succeeded. I had to clean up my clone to reproduce the issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
