joewitt commented on a change in pull request #3782: [NIFI-6735] - validate
components before restarting processors follow…
URL: https://github.com/apache/nifi/pull/3782#discussion_r330347559
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ParameterContextResource.java
##########
@@ -867,6 +867,12 @@ private ParameterContextEntity
updateParameterContext(final AsynchronousWebReque
updatedEntity = performParameterContextUpdate(asyncRequest, uri,
replicateRequest, revision, updatedContextEntity);
logger.info("Successfully updated Parameter Context with ID {}",
updatedContextEntity.getId());
} finally {
+ if (!asyncRequest.isCancelled()) {
Review comment:
@rfellows I am not quite sure as I'm not familiar enough with this
particular set of code but if this is attempting a synchronous validation
operation so that when we attempt restart we should be good - this might not be
the way to go as we tried to move away from such things. Rather, we'd want to
have restart happen after validation has had some time to occur and/or we
attempt it a few times to allow that to happen (before we give up). If someone
else can review/comment that would be good too if there is greater familiarity
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
