MikeThomsen commented on a change in pull request #3771: NIFI-6723: Enrich 
processor-related and JVM GC metrics in Prometheus Reporting Task
URL: https://github.com/apache/nifi/pull/3771#discussion_r330549252
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-prometheus-bundle/nifi-prometheus-reporting-task/src/main/java/org/apache/nifi/reporting/prometheus/api/PrometheusMetricsUtil.java
 ##########
 @@ -249,6 +257,18 @@
             .labelNames("instance")
             .register(JVM_REGISTRY);
 
+    private static final Gauge JVM_GC_RUNS = Gauge.build()
+            .name("nifi_jvm_gc_runs")
+            .help("NiFi JVM GC number of runs")
+            .labelNames("inctance", "gc_name")
+            .register(JVM_REGISTRY);
+
+    private static final Gauge JVM_GC_TIME = Gauge.build()
+            .name("nifi_jvm_gc_time")
+            .help("NiFi JVM GC time in milliseconds")
+            .labelNames("inctance", "gc_name")
 
 Review comment:
   Same here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to