arpadboda commented on a change in pull request #656: MINIFI-1013 Used soci library. URL: https://github.com/apache/nifi-minifi-cpp/pull/656#discussion_r331044170
########## File path: extensions/sql/processors/ExecuteSQL.cpp ########## @@ -0,0 +1,139 @@ +/** + * @file ExecuteSQL.cpp + * ExecuteSQL class declaration + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "ExecuteSQL.h" + +#include <vector> +#include <queue> +#include <map> +#include <set> +#include <sstream> +#include <stdio.h> +#include <string> +#include <iostream> +#include <memory> +#include <codecvt> +#include <soci.h> + +#include "io/DataStream.h" +#include "core/ProcessContext.h" +#include "core/ProcessSession.h" +#include "Exception.h" +#include "utils/OsUtils.h" +#include "data/DatabaseConnectors.h" +#include "data/JSONSQLWriter.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace processors { + + const std::string ExecuteSQL::ProcessorName("ExecuteSQL"); + +static core::Property DBCControllerService( + core::PropertyBuilder::createProperty("DB Controller Service")->isRequired(true)->withDescription("Database Controller Service.")->supportsExpressionLanguage(true)->build()); + +static core::Property s_SQLSelectQuery( + core::PropertyBuilder::createProperty("SQL select query")->isRequired(true)->withDefaultValue("System")->withDescription( + "The SQL select query to execute. The query can be empty, a constant value, or built from attributes using Expression Language. " + "If this property is specified, it will be used regardless of the content of incoming flowfiles. " + "If this property is empty, the content of the incoming flow file is expected to contain a valid SQL select query, to be issued by the processor to the database. " + "Note that Expression Language is not evaluated for flow file contents.")->supportsExpressionLanguage(true)->build()); + +static core::Property MaxRowsPerFlowFile( + core::PropertyBuilder::createProperty("Max Rows Per Flow File")->isRequired(true)->withDefaultValue<int>(0)->withDescription( + "The maximum number of result rows that will be included intoi a flow file. If zero then all will be placed into the flow file")->supportsExpressionLanguage(true)->build()); + +core::Relationship ExecuteSQL::Success("success", "Relationship for successfully consumed events."); + +ExecuteSQL::ExecuteSQL(const std::string& name, utils::Identifier uuid) + : core::Processor(name, uuid), max_rows_(0), + logger_(logging::LoggerFactory<ExecuteSQL>::getLogger()) { +} + +ExecuteSQL::~ExecuteSQL() { +} + +void ExecuteSQL::initialize() { + //! Set the supported properties + setSupportedProperties( { DBCControllerService, s_SQLSelectQuery, MaxRowsPerFlowFile }); + + //! Set the supported relationships + setSupportedRelationships( { Success }); +} + +void ExecuteSQL::onSchedule(const std::shared_ptr<core::ProcessContext> &context, const std::shared_ptr<core::ProcessSessionFactory> &sessionFactory) { + context->getProperty(DBCControllerService.getName(), db_controller_service_); + context->getProperty(s_SQLSelectQuery.getName(), sqlSelectQuery_); + context->getProperty(MaxRowsPerFlowFile.getName(), max_rows_); + + database_service_ = std::dynamic_pointer_cast<sql::controllers::DatabaseService>(context->getControllerService(db_controller_service_)); + if (database_service_ == nullptr) { + throw minifi::Exception(PROCESS_SCHEDULE_EXCEPTION, "DB Controller Service must be defined"); Review comment: I think this completely messes up everything. Even though I would be very happy to do this, MiNiFi framework doesn't handle this properly yet. What I did in OPC processor recently is to have a bool member, by default initialised false and set that true in case onSchedule was executed properly. In case it's false when onTrigger is called, onTrigger simply logs and returns. Longer term I would prefer to have some way more sophisticated way to handle configuration errors in framework level. Exceptions thrown in onSchedule should be handled gracefully, misconfigured processors are not being triggered, etc... If you feel the motivation feel free to create a follow-up ticket and submit a POC. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
