ekovacs commented on a change in pull request #235: NIFIREG-325: support for
node identity group
URL: https://github.com/apache/nifi-registry/pull/235#discussion_r332057549
##########
File path:
nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/security/authorization/file/FileAccessPolicyProvider.java
##########
@@ -147,6 +149,7 @@ private static JAXBContext initializeJaxbContext(final
String contextPath) {
static final String PROP_NIFI_IDENTITY_PREFIX = "NiFi Identity ";
static final String PROP_USER_GROUP_PROVIDER = "User Group Provider";
+ static final String PROP_NIFI_IDENTITY_GROUP_NAME = "Identity Group Name";
Review comment:
Initially i was going to call it `NiFi Identity Group` or `NiFi Identity
Group Name` but then i realised that:
if no node identites are present, only NiFi Identity Group Name, then the
`PROP_NIFI_IDENTITY_PREFIX` would regex match it, and would create user
authorizations for it. Thus i opted to name it differently to avoid false
instance `NiFi Identity` matches
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
