bbende commented on a change in pull request #235: NIFIREG-325: support for
node identity group
URL: https://github.com/apache/nifi-registry/pull/235#discussion_r332062820
##########
File path:
nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/security/authorization/file/FileAccessPolicyProvider.java
##########
@@ -215,6 +219,23 @@ public void onConfigured(AuthorizerConfigurationContext
configurationContext) th
}
}
+ PropertyValue identityGroupNameProp =
configurationContext.getProperty(PROP_NIFI_IDENTITY_GROUP_NAME);
+ String identityGroupName = (identityGroupNameProp != null &&
identityGroupNameProp.isSet()) ? identityGroupNameProp.getValue() : null;
+ if (identityGroupName != null) {
Review comment:
I haven't dug into the difference yet, but in NiFi if you have `<property
name="Node Group"></property>`, it doesn't look for the group and continues on
with normal start up, but in registry if you have `<property name="Identity
Group Name"></property>` then it throws an exception:
`SecurityProviderCreationException: Authorizations node group '' could not
be found`
We should probably try to have the same behavior here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
