bakaid commented on a change in pull request #660: MINIFICPP-1058 -
ConsumeWindowsEventLog should have a property that e…
URL: https://github.com/apache/nifi-minifi-cpp/pull/660#discussion_r333421201
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -200,6 +211,16 @@ void ConsumeWindowsEventLog::onSchedule(const
std::shared_ptr<core::ProcessConte
subscribe(context);
}
+ std::string mode;
+ context->getProperty(OutputFormat.getName(), mode);
+
+ if (mode == "Both" || mode == "XML") {
Review comment:
These won't reset the variables to false if the configuration changes in
that direction.
I suggest `writeXML_ = mode == "Both" || mode == "XML";` and
`writePlainText_ = mode == "Both" || mode == "Plaintext";`, respectively.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
