[
https://issues.apache.org/jira/browse/NIFI-6758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948705#comment-16948705
]
ASF subversion and git services commented on NIFI-6758:
-------------------------------------------------------
Commit 5238dc20b1868ada96dc55d38dcbdf401a129a97 in nifi's branch
refs/heads/master from Endre Zoltan Kovacs
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5238dc2 ]
NIFI-6758: allow pre-unpacked nar's to be recorded in ExtensionMapping
- fixing resource leak
This closes #3806.
Signed-off-by: Bryan Bende <[email protected]>
> create bundle coordinate map in separate phase
> ----------------------------------------------
>
> Key: NIFI-6758
> URL: https://issues.apache.org/jira/browse/NIFI-6758
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Endre Kovacs
> Assignee: Endre Kovacs
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In NarUnpacker
> https://github.com/apache/nifi/blob/9a496fe9d2681fca06fb6f071d0fa39d71bc5268/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java#L131
> a bundleCoordinate map is populated during a for loop which un-packs the nars
> found in extension work dir.
> *This is great.*
> However if we want to optimize nifi size, we could keep only the un-packed
> the nars, delete the original nar archive files, and save hundreds of MBs of
> diskspace.
> In this case, the bundle-coordinate map is not populated, as the nar files
> are no longer present, only their unpacked , directory version are present.
> Such empty bundle-coordinate map will result in an empty ExtensionMapping
> which is returned, and is supplied to downstream components, eg.:
> jettyserver puts it on context for web docs servlet
> https://github.com/apache/nifi/blob/9a496fe9d2681fca06fb6f071d0fa39d71bc5268/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java#L1005
> and the nifi-web-docs DocumentationController uses it:
> https://github.com/apache/nifi/blob/9a496fe9d2681fca06fb6f071d0fa39d71bc5268/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-docs/src/main/java/org/apache/nifi/web/docs/DocumentationController.java#L60
> In such case, the resulting effect is that when the user does a right click
> on a processor, and clicks view-usage
> None of the processors are showing in the help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
