kevdoran commented on a change in pull request #3802: NIFI-6755 "Chron Trigger Tutorial" link broken in NiFi User Guide URL: https://github.com/apache/nifi/pull/3802#discussion_r334001024
########## File path: nifi-docs/src/main/asciidoc/user-guide.adoc ########## @@ -627,7 +627,7 @@ For example: * The string `0 20 14 ? * MON-FRI` indicates that you want to schedule the processor to run at 2:20 PM every Monday through Friday. * The string `0 15 10 ? * 6L 2011-2017` indicates that you want to schedule the processor to run at 10:15 AM, on the last Friday of every month, between 2011 and 2017. -For additional information and examples, see the link:http://www.quartz-scheduler.org/documentation/quartz-2.x/tutorials/crontrigger.html[Chron Trigger Tutorial^] in the Quartz documentation. +For additional information and examples on cron triggers, see tutorials in link:http://www.quartz-scheduler.org/documentation/[Quartz Documentation^]. Review comment: I understand that the goal of this fix is to replace the existing (broken) link with one that does not contain a specific version in the URL path and therefore is less likely to break again in the future. However, the downside is that this change would require the reader of the NiFi documentation to both (1) know which version of Quartz is used by NiFi, and (2) navigate the Quartz Documentation to find the tutorial on cron triggers. I suggest the following compromise, which includes the deep link to the specific tutorial at the correct version, and also a fallback link to the overall Quartz documentation: ```suggestion For additional information and examples, see the link:https://www.quartz-scheduler.org/documentation/quartz-2.2.2/tutorials/tutorial-lesson-06.html[cron triggers tutorial] in the link:https://www.quartz-scheduler.org/documentation/[Quartz Documentation^]. ``` Note: we prefer to use `https` links wherever possible, so I've updated that in my suggestion as well. Let me know if you are ok with these suggestions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
