kevdoran commented on issue #230: NIFIREG-321 Integrate revision concept into UI, REST API, and service… URL: https://github.com/apache/nifi-registry/pull/230#issuecomment-541764241 Thanks @bbende. Take your time on making any changes, I know this PR has been up a while, so no rush context-switching to get back to it. Regarding the ongoing points we are discussing: 1. The example you gave, someone renaming something to "do not delete" or "WIP" or something like that is a good counter example. I don't really have a problem with checking revision on delete as it doesn't really do any harm to check, and it could catch something worth preventing in cases we cannot think of, so let's leave that as is. Regarding the 400/409 issue, ideally/conceptually, my preference would be to following: Entity does not exist: 404 is returned for all operations (GET, PUT, DELETE) Entity exists, revision is stale: 409 Any other reason / malformed request / failed revision check / etc: 400 That said, I think this needs to be balanced with feasibly. I know in some cases in the JDBC impl that the exception is being thrown based on the results of executing a SQL statement, and if we think that result could be due to multiple reasons that are difficult to determine, then I would be ok using a 400 as a catch all for "failed do to one of many potential reasons". 2. Sounds good. 3. Good with this as a follow on Jira. Thanks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
