mcgilman commented on issue #3795: NIFI-6703: Add Stateless NiFi to CLI URL: https://github.com/apache/nifi/pull/3795#issuecomment-542814145 Thanks for the PR @SamHjelmfelt! And thanks for the subsequent commit. This approach feels better and is inline with our existing approach with NiFi. Two additional comments. 1) When I build, the `dockermaven-stateless` fails because it seems to be running before `nifi-assembly`. Looking at the maven build order, it seems as though the order in the pom is a last resort. Something appears to be allowing the docker builds to run before the `nifi-assembly`. I think we should try to prevent this. I successfully did so by adding a dependency to `nifi-docker` (so all docker projects can benefit) on `nifi-assembly`. > <dependencies> > <dependency> > <groupId>org.apache.nifi</groupId> > <artifactId>nifi-assembly</artifactId> > <classifier>bin</classifier> > <version>1.10.0-SNAPSHOT</version> > <type>zip</type> > </dependency> > </dependencies> In order for this to work, I had to attach the resulting artifacts in the maven-assembly-plugin configuration of `nifi-assembly`. I am not sure if this is the best solution to this issue. This is arguably a separate concern that we could file a JIRA for addressing in the future. 2) Once I got the build to execute in the right order, the `dockermaven-stateless` build seems to fail with: > [INFO] --- exec-maven-plugin:1.6.0:exec (Docker integration tests) @ dockermaven-stateless --- > [ERROR] Command execution failed. > java.io.IOException: Cannot run program "/Users/mgilman/Development/apache/nifi/nifi-docker/dockermaven-stateless/integration-test.sh" This file appears to have been removed in this PR. Did you intend to also remove it from the pom?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
