[ 
https://issues.apache.org/jira/browse/NIFI-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-6784:
------------------------------
    Description: 
When attempting to build NiFi and generate the Docker images the build fails. 
The docker images have a dependency on the generated assembly. Specifically, 
they attempt to directly access the generated `zip` archive.

Unfortunately, this does not appear to be enforced via the maven reactor. When 
building with the docker profile enabled, the build fails because the docker 
images are built prior to the NiFi assembly. This may not be an issue if the 
usual process is to build NiFi without the docker profile enabled and then to 
build the docker images subsequently. However, we should be able to build it 
all in a single execution.

I attempted to do so by adding a dependency in `nifi-docker` on:

{code}
<dependencies>
    <dependency>
        <groupId>org.apache.nifi</groupId>
        <artifactId>nifi-assembly</artifactId>
        <classifier>bin</classifier>
        <version>1.10.0-SNAPSHOT</version>
        <type>zip</type>
    </dependency>
</dependencies>
{code}

In addition to this change, I also had to attach the resulting artifacts in the 
maven-assembly-plugin configuration of nifi-assembly.

This seemed to work, how additional work is likely needed to have the docker 
images to actually build with the dependent maven artifacts. Currently, the 
docker images are built via ant commands that directly access the built 
assembly by navigating outside of their own directories.

  was:
When attempting to build NiFi and generate the Docker images the build fails. 
The docker images have a dependency on the generated assembly. Specifically, 
they attempt to directly access the generated `zip` archive.

Unfortunately, this does not appear to be enforced via the maven reactor. When 
building with the docker profile enabled, the build fails because the docker 
images are built prior to the NiFi assembly. This may not be an issue if the 
usual process is to build NiFi without the docker profile enabled and then to 
build the docker images subsequently. However, we should be able to build it 
all in a single execution.

I attempted to do so by adding a dependency to `nifi-docker` on:

{code}
<dependencies>
    <dependency>
        <groupId>org.apache.nifi</groupId>
        <artifactId>nifi-assembly</artifactId>
        <classifier>bin</classifier>
        <version>1.10.0-SNAPSHOT</version>
        <type>zip</type>
    </dependency>
</dependencies>
{code}

In addition to this change I also had to attach the the resulting artifacts in 
the maven-assembly-plugin configuration of nifi-assembly.

This seemed to work, how additional work is likely needed to have the docker 
images to actually build with the dependent maven artifacts. Currently, the 
docker images are built via ant commands that directly access the built 
assembly by navigating outside of their own directories.


> Unable to build docker modules
> ------------------------------
>
>                 Key: NIFI-6784
>                 URL: https://issues.apache.org/jira/browse/NIFI-6784
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Tools and Build
>            Reporter: Matt Gilman
>            Priority: Major
>
> When attempting to build NiFi and generate the Docker images the build fails. 
> The docker images have a dependency on the generated assembly. Specifically, 
> they attempt to directly access the generated `zip` archive.
> Unfortunately, this does not appear to be enforced via the maven reactor. 
> When building with the docker profile enabled, the build fails because the 
> docker images are built prior to the NiFi assembly. This may not be an issue 
> if the usual process is to build NiFi without the docker profile enabled and 
> then to build the docker images subsequently. However, we should be able to 
> build it all in a single execution.
> I attempted to do so by adding a dependency in `nifi-docker` on:
> {code}
> <dependencies>
>     <dependency>
>         <groupId>org.apache.nifi</groupId>
>         <artifactId>nifi-assembly</artifactId>
>         <classifier>bin</classifier>
>         <version>1.10.0-SNAPSHOT</version>
>         <type>zip</type>
>     </dependency>
> </dependencies>
> {code}
> In addition to this change, I also had to attach the resulting artifacts in 
> the maven-assembly-plugin configuration of nifi-assembly.
> This seemed to work, how additional work is likely needed to have the docker 
> images to actually build with the dependent maven artifacts. Currently, the 
> docker images are built via ant commands that directly access the built 
> assembly by navigating outside of their own directories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to