joewitt commented on a change in pull request #3676: NIFI-6597 Azure Event Hub
Version Update
URL: https://github.com/apache/nifi/pull/3676#discussion_r336019251
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/GetAzureEventHub.java
##########
@@ -70,7 +74,6 @@
@WritesAttribute(attribute = "eventhub.partition", description = "The
name of the Azure Partition from which the message was pulled")
})
public class GetAzureEventHub extends AbstractProcessor {
Review comment:
this processor I suspect will be rarely used in comparison to
ConsumeAzureEVentHub anyway since this doesn't utilize the record reader/writer
mechanism. The other while using a single thread as currently implemented will
probably offer a better user experience and performance characteristic. If
necessary that one could be updated to have multiple threads operating at once.
This one will have multiple threads but writing of data not being record
oriented will mean overall throughput will drag. This is the same reason we
went from ConsumeKafka to ConsumeKafkaRecord design. So with that in mind I
think we can stress a bit less on this one. As long is it functions correctly,
the thread pool is understood by the user, and is destroyed correctly - then
this is prob fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
