arpadboda commented on a change in pull request #666: MINIFICPP-1070 - Fixed
handling of PKCS12 certificates
URL: https://github.com/apache/nifi-minifi-cpp/pull/666#discussion_r337778920
##########
File path: libminifi/src/controllers/SSLContextService.cpp
##########
@@ -80,7 +82,16 @@ bool SSLContextService::configure_ssl_context(SSL_CTX *ctx)
{
X509_free(cert);
Review comment:
My gut feeling says that whenever we do this we leak the page pointed by
"ca".
PKCS12_parse allocates that as well, so I think we need to free it.
I would also prefer using lock_guards for the resources here to avoid leaks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
