ekovacs commented on issue #245: NIFIREG-252: adding mavendocker build profile URL: https://github.com/apache/nifi-registry/pull/245#issuecomment-545815844 > Thanks for the contribution @ekovacs! > > Overall this looks good to me. > > I had one inline suggestion about disabling a plugin execution under certain conditions, but that is more of a nice-to-have than a deal-breaker. > > At some point I would like to try to combine this with the `nifi-registry-docker` module, especially to de-duplicate items such as the shell scripts that get added to the image, but we can save that for a future improvement to the project. > > Ran the build and the output is working for me. This will help with testing, esp. integration tests with nifi. > > Thanks! at first, i put `dockermaven` project as a child of nifi-registry-docker (which is nifi-registry-core's child), but then i was unable to make sure that `nifi-registry-assembly` would execute prior to `dockermaven` (because `nifi-registry-core` must be built prior to `nifi-registry-assembly`), so i put it under the root directly, and specified `nifi-registry-docker-maven` later then `nifi-registry-assembly` in the root `pom.xml`'s module list, so this way i have the built artifacts ready when starting the docker build. i could have moved the existing `nifi-registry-docker` to the root to have docker things in one place, but i didn't want to break any external infra which may expect `nifi-registry-docker` at the currrent location
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
