ekovacs commented on a change in pull request #245: NIFIREG-252: adding mavendocker build profile URL: https://github.com/apache/nifi-registry/pull/245#discussion_r338448518
########## File path: nifi-registry-docker-maven/dockermaven/pom.xml ########## @@ -0,0 +1,101 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor + license agreements. See the NOTICE file distributed with this work for additional + information regarding copyright ownership. The ASF licenses this file to + You under the Apache License, Version 2.0 (the "License"); you may not use + this file except in compliance with the License. You may obtain a copy of + the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required + by applicable law or agreed to in writing, software distributed under the + License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS + OF ANY KIND, either express or implied. See the License for the specific + language governing permissions and limitations under the License. --> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <artifactId>nifi-registry-docker-maven</artifactId> + <groupId>org.apache.nifi.registry</groupId> + <version>1.0.0-SNAPSHOT</version> + </parent> + <version>1.0.0-SNAPSHOT</version> + + <artifactId>dockermaven</artifactId> + + <profiles> + <profile> + <id>docker</id> + <build> + <plugins> + <plugin> + <groupId>com.spotify</groupId> + <artifactId>dockerfile-maven-plugin</artifactId> + <version>1.3.5</version> + <executions> + <execution> + <id>default</id> + <goals> + <goal>build</goal> + </goals> + <configuration> + <buildArgs> + <UID>1000</UID> + <GID>1000</GID> + <NIFI_REGISTRY_VERSION>${project.version}</NIFI_REGISTRY_VERSION> + <NIFI_REGISTRY_BINARY>target/nifi-registry-${project.version}-bin.zip</NIFI_REGISTRY_BINARY> + </buildArgs> + <repository>apache/nifi-registry</repository> + <tag>${project.version}-dockermaven</tag> + </configuration> + </execution> + </executions> + </plugin> + <!-- Copy generated artifacts --> + <plugin> + <artifactId>maven-antrun-plugin</artifactId> + <version>1.8</version> + <executions> + <execution> + <id>copy-for-docker</id> + <phase>process-sources</phase> + <configuration> + <target name="copy assembly to nifi-registry-docker for image build"> + <copy todir="${project.basedir}/target" overwrite="true" flatten="true"> + <fileset dir="${project.basedir}/../../nifi-registry-assembly/target" includes="*.zip"> + <include name="*.zip" /> + </fileset> + </copy> + </target> + </configuration> + <goals> + <goal>run</goal> + </goals> + </execution> + </executions> + </plugin> + + <plugin> + <artifactId>exec-maven-plugin</artifactId> + <groupId>org.codehaus.mojo</groupId> + <executions> + <execution> + <id>Docker integration tests</id> + <phase>integration-test</phase> + <goals> + <goal>exec</goal> + </goals> + <configuration> + <arguments> + <argument>${project.version}-dockermaven</argument> + <argument>${project.version}</argument> + </arguments> + <executable>${project.basedir}/integration-test.sh</executable> + </configuration> + </execution> + </executions> + </plugin> Review comment: updated PR with _skipping_ on `-DskipTests` now this will be printed, if `skipTests` is set: ``` [INFO] --- exec-maven-plugin:1.3.2:exec (Docker integration tests) @ dockermaven --- [INFO] skipping execute as per configuraion ``` also, please note that this test would only run, when `integration-test` or later maven lifecycle phase (eg.: `verify`) is specified. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
