ivan1221 commented on a change in pull request #3552: NIFI-6395: Thread-safety
bug fixed and added new flag property to han…
URL: https://github.com/apache/nifi/pull/3552#discussion_r342016770
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CountText.java
##########
@@ -213,10 +221,10 @@ public void onTrigger(ProcessContext context,
ProcessSession processSession) thr
}
AtomicBoolean error = new AtomicBoolean();
- lineCount = 0;
- lineNonEmptyCount = 0;
- wordCount = 0;
- characterCount = 0;
+ final AtomicInteger lineCount = new AtomicInteger(0);
+ final AtomicInteger lineNonEmptyCount = new AtomicInteger(0);
+ final AtomicInteger wordCount = new AtomicInteger(0);
+ final AtomicInteger characterCount = new AtomicInteger(0);
Review comment:
To change this implementation by local primitive variables to the lambda
expression, you should refactor a lot of code, for example the way in which the
flowfile attributes are being configured when transferring to the success
relationship.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services