nghiaxlee commented on a change in pull request #672: MINIFICPP-1043 - FetchOPC
should support reporting changes only
URL: https://github.com/apache/nifi-minifi-cpp/pull/672#discussion_r342810195
##########
File path: extensions/opc/src/opc.cpp
##########
@@ -220,10 +220,31 @@ NodeData Client::getNodeData(const
UA_ReferenceDescription *ref, const std::stri
nodedata.attributes["NodeID type"] = "numeric";
}
nodedata.attributes["Browsename"] = browsename;
+ // TODO: Base path is always ""
nodedata.attributes["Full path"] = basePath + "/" + browsename;
nodedata.dataTypeID = UA_TYPES_COUNT;
UA_Variant* var = UA_Variant_new();
if(UA_Client_readValueAttribute(client_, ref->nodeId.nodeId, var) ==
UA_STATUSCODE_GOOD && var->type != NULL && var->data != NULL) {
+ // Because the timestamps are eliminated in readValueAttribute for
simplification
Review comment:
Yes, this code part is a trimmed down version of `UA_readValueAttribute`
with a slight modification. Despite checking lazy mode before running might be
better, I then have to pass the lazy flag from fetchopc processor to this
function, which I am not quite into.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
