mattyb149 commented on a change in pull request #3874: NIFI-6842 - Introduce
MetricsEventReportingTask
URL: https://github.com/apache/nifi/pull/3874#discussion_r343117177
##########
File path: nifi-assembly/pom.xml
##########
@@ -878,6 +878,18 @@ language governing permissions and limitations under the
License. -->
<version>1.11.0-SNAPSHOT</version>
<type>nar</type>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-easyrules-nar</artifactId>
Review comment:
Do we need this NAR here? I would think we'd interact with the Rules Engine
using the `RulesEngineService` interface in `nifi-rules-engine-service-api`. Or
is it included so there's a guaranteed implementation of the interface? In that
case I'm good with it, or perhaps we should consider trivial implementations in
the API, such as `AlwaysFireRulesService` and/or `NeverFireRulesService`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
