turcsanyip commented on issue #3796: WIP: NIFI-6752 Add ASN.1 RecordReader URL: https://github.com/apache/nifi/pull/3796#issuecomment-553895293 I tested the controller service with different configs (base case, record field, record field containing list, custom iterator) and it looks good to me. I think the class loading logic could be simplified in either of the following ways: option 1) - set `dynamicallyModifiesClasspath(true)` on `MODEL_CLASS_PATHS` - specify `@RequiresInstanceClassLoading` on `JASN1Reader` - call Class.forName(rootClassName) in `JASN1RecordReader` to load the model class (and similarly the iterator class) option 2) - set `dynamicallyModifiesClasspath(true)` on `MODEL_CLASS_PATHS` - call `Thread.currentThread().getContextClassLoader().loadClass(rootClassName)` to load the model class (and similarly the iterator class) I tried out both versions with the test cases mentioned above and they worked fine.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
