mattyb149 commented on a change in pull request #3890: NIFI-6871: Added 
HikariCPConnectionPool controller service
URL: https://github.com/apache/nifi/pull/3890#discussion_r347621579
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/pom.xml
 ##########
 @@ -68,6 +68,11 @@
             <artifactId>nifi-record</artifactId>
             <version>1.11.0-SNAPSHOT</version>
         </dependency>
+        <dependency>
+            <groupId>com.zaxxer</groupId>
+            <artifactId>HikariCP</artifactId>
 
 Review comment:
   I don't believe so, it is ASL 2.0 licensed with no NOTICE in the project.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to