bakaid commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r348507056
########## File path: nanofi/src/ecu_api/ecuapi.c ########## @@ -0,0 +1,835 @@ +/** Review comment: The concept of having a fix set of input-output modules and switch-casing through them in all of these functions is not very extensible or generic, and code is not too nice this way either. I think it is reasonable to expect that we, or the user might want to expand on these capabilities. Therefore I think it would be better to have an input-output module interface (practically a struct of function pointers) defined for these and a global map to which they can be registered. Each input-output module can then implement these functions and register itself in the map, which we can access from these functions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
