turcsanyip commented on a change in pull request #3894: NIFI-6884 - Native library loading fixed/improved URL: https://github.com/apache/nifi/pull/3894#discussion_r349327915
########## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarClassLoader.java ########## @@ -116,10 +122,13 @@ * Maven NAR plugin will fail to build the NAR. * </p> Review comment: I think the javadoc of this class (which describes the NAR structure / java classloading in detail) should be updated with the concept of the native lib handling too. Usage of `-Djava.library.path` system property also needs to be documented (the Admin Guide may be the right place for it). Updating the description of the properties having `dynamicallyModifiesClasspath(true)` also needed I think. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
