arpadboda commented on a change in pull request #661: MINIFICPP-1022 -
Refactored third party build system
URL: https://github.com/apache/nifi-minifi-cpp/pull/661#discussion_r349583024
##########
File path: cmake/BuildTests.cmake
##########
@@ -143,21 +128,10 @@ FOREACH(testfile ${NANOFI_UNIT_TESTS})
target_include_directories(${testfilename} BEFORE PRIVATE
"${CMAKE_SOURCE_DIR}/libminifi/test")
appendIncludes("${testfilename}")
target_link_libraries(${testfilename} ${CMAKE_THREAD_LIBS_INIT}
${CATCH_MAIN_LIB} ${TEST_BASE_LIB} nanofi)
-
- if (APPLE)
- # minifi-standard-processors
- target_link_libraries (${testfilename} -Wl,-all_load
minifi-standard-processors nanofi)
- elseif(NOT WIN32)
- target_link_libraries (${testfilename} -Wl,--whole-archive
minifi-standard-processors -Wl,--no-whole-archive)
- else()
- set(WIN32_ARCHIVES "${WIN32_ARCHIVES}
/WHOLEARCHIVE:minifi-standard-processors")
- target_link_libraries (${testfilename} minifi-standard-processors)
- endif ()
-
- if(WIN32)
- set_target_properties(${testfilename} PROPERTIES LINK_FLAGS
"${WIN32_ARCHIVES}")
- endif()
-
+
+ target_wholearchive_library(${testfilename} minifi-standard-processors)
+# target_wholearchive_library(${testfilename} nanofi)
Review comment:
Please remove this! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
