markap14 commented on a change in pull request #3894: NIFI-6884 - Native
library loading fixed/improved
URL: https://github.com/apache/nifi/pull/3894#discussion_r349649858
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarClassLoader.java
##########
@@ -205,26 +216,41 @@ private void updateClasspath(File root) throws
IOException {
}
@Override
- protected String findLibrary(final String libname) {
+ public String findLibrary(String libname) {
Review comment:
Gotcha. Thanks for clarifying. I know there are sometimes some oddities like
this in Java that do require overriding a method and calling the superclass.
But 80% of the time when I do it, it's because I refactored and it just didn't
even occur to me to delete it. Just figured I'd check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
