HorizonNet commented on a change in pull request #248: NIFIREG-227
GitFlowPersistenceProvider option to clone repo on startup
URL: https://github.com/apache/nifi-registry/pull/248#discussion_r350400268
##########
File path:
nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/flow/git/GitFlowMetaData.java
##########
@@ -136,36 +136,50 @@ private Repository openRepository(final File
gitProjectRootDir) throws IOExcepti
}
private static boolean hasAtLeastOneReference(Repository repo) {
- logger.info(repo.toString());
+ logger.info("Checking references for repository {}", repo.toString());
for (Ref ref : repo.getAllRefs().values()) {
- if (ref.getObjectId() == null)
+ if (ref.getObjectId() == null) {
continue;
+ }
return true;
}
return false;
}
+ /**
+ * Check if provided local repository exists or not at given 'Flow Storage
Directory' in providers.xml
+ * @param localRepo file object of 'Flow Storage Directory'
Review comment:
Better
{@link File} object of the 'Flow Storage Directory' configuration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
