msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r350929190
########## File path: nanofi/CMakeLists.txt ########## @@ -23,32 +23,67 @@ IF(POLICY CMP0048) CMAKE_POLICY(SET CMP0048 OLD) ENDIF(POLICY CMP0048) -include_directories(include) -include_directories(../libminifi/include ../thirdparty/cron ../thirdparty/spdlog-20170710/include) -include_directories(../thirdparty/ut) +include(ExternalProject) + +if(MSVC) + set(CBOR_RESTRICT_SPECIFIER "") +elseif(APPLE) + set(CBOR_RESTRICT_SPECIFIER "restrict") +else() + set(CBOR_RESTRICT_SPECIFIER "__restrict__") +endif() + +ExternalProject_Add( + libcbor-external Review comment: I have tested this with coap_server.c and c2_client.c in nanofi/ecu. The coap_server.c stands as a C2 server listening for heartbeats from ecus. c2_client.c stands as a c2 client requesting operations on ecu via coap_server. I will write unit tests for testing the serde of c2 protocol including heartbeats and c2 operations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
