arpadboda commented on a change in pull request #683: MINIFICPP-1087 - Proper
handling of errors during onSchedule calls
URL: https://github.com/apache/nifi-minifi-cpp/pull/683#discussion_r351185994
##########
File path: CPPLINT.cfg
##########
@@ -1,3 +1,3 @@
set noparent
-filter=-runtime/reference
+filter=-runtime/reference,-runtime/string
Review comment:
Yes, it's for the
```
static const std::string
```
members in KamikazeProcessor, but it's not the only place we would like to
have it, see further references:
https://github.com/apache/nifi-minifi-cpp/pull/670/files#diff-dfeecc634b3aea462f1f8dc52c2abaceR50
This rule forces people to use raw pointers instead of string, which is
simply error-prone, but doesn't add value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
