arpadboda commented on a change in pull request #687: MINIFICPP-1092 - Make 
CoAP compile and work on Windows
URL: https://github.com/apache/nifi-minifi-cpp/pull/687#discussion_r351725271
 
 

 ##########
 File path: extensions/coap/server/CoapServer.h
 ##########
 @@ -18,24 +18,26 @@
 
 #ifndef EXTENSIONS_COAP_SERVER_COAPSERVER_H_
 #define EXTENSIONS_COAP_SERVER_COAPSERVER_H_
+
 #include "core/Connectable.h"
 #include "coap_server.h"
 #include "coap_message.h"
 #include <coap2/coap.h>
 #include <functional>
 #include <thread>
 #include <future>
+
 namespace org {
 namespace apache {
 namespace nifi {
 namespace minifi {
 namespace coap {
 
-enum METHOD {
-  GET,
-  POST,
-  PUT,
-  DELETE
+enum class Method {
 
 Review comment:
   👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to