bakaid commented on a change in pull request #683: MINIFICPP-1087 - Proper
handling of errors during onSchedule calls
URL: https://github.com/apache/nifi-minifi-cpp/pull/683#discussion_r351735557
##########
File path: libminifi/src/core/yaml/YamlConfiguration.cpp
##########
@@ -61,6 +61,21 @@ core::ProcessGroup
*YamlConfiguration::parseRootProcessGroupYaml(YAML::Node root
this->name_ = flowName;
+ if (rootFlowNode["onschedule retry interval"]) {
+ int64_t onScheduleRetryPeriodValue = -1;
+ std::string onScheduleRetryPeriod = rootFlowNode["onschedule retry
interval"].as<std::string>();
+ logger_->log_debug("parseRootProcessGroup: onschedule retry period =>
[%s]", onScheduleRetryPeriod);
+
+ core::TimeUnit unit;
+
+ if (core::Property::StringToTime(onScheduleRetryPeriod,
onScheduleRetryPeriodValue, unit)
+ && core::Property::ConvertTimeUnitToMS(onScheduleRetryPeriodValue,
unit, onScheduleRetryPeriodValue)
+ && group) {
+ logger_->log_debug("parseRootProcessGroup: onschedule retry => [%ll]
ms", onScheduleRetryPeriodValue);
Review comment:
`%ll` is a length field without a type field, so it won't consume the
int64_t and print `parseRootProcessGroup: onschedule retry => [%] ms`.
It should be `%lld`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
