markap14 commented on issue #3894: NIFI-6884 - Native library loading fixed/improved URL: https://github.com/apache/nifi/pull/3894#issuecomment-561316411 Awesome, thanks, @tpalfy! Looking at the Travis output, I see there is a test failure: ``` [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.009 s - in org.apache.nifi.nar.TestLoadNativeLibFromNar [INFO] Running org.apache.nifi.nar.TestLoadNativeLibViaSystemProperty [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.046 s <<< FAILURE! - in org.apache.nifi.nar.TestLoadNativeLibViaSystemProperty [ERROR] org.apache.nifi.nar.TestLoadNativeLibViaSystemProperty Time elapsed: 0.046 s <<< ERROR! org.junit.AssumptionViolatedException: got: <false>, expected: is <true> at org.apache.nifi.nar.TestLoadNativeLibViaSystemProperty.setUpClass(TestLoadNativeLibViaSystemProperty.java:52) [ERROR] org.apache.nifi.nar.TestLoadNativeLibViaSystemProperty Time elapsed: 0.046 s <<< ERROR! java.lang.NullPointerException at org.apache.nifi.nar.TestLoadNativeLibViaSystemProperty.tearDownSuite(TestLoadNativeLibViaSystemProperty.java:60) [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] org.apache.nifi.nar.TestLoadNativeLibViaSystemProperty.org.apache.nifi.nar.TestLoadNativeLibViaSystemProperty [ERROR] Run 1: TestLoadNativeLibViaSystemProperty.setUpClass:52 » AssumptionViolated got: <fa... [ERROR] Run 2: TestLoadNativeLibViaSystemProperty.tearDownSuite:60 » NullPointer [INFO] [INFO] [ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 1 ``` I think it's because the #tearDownSuite method is calling `System.setProperty` with a null value because the `assumeTrue` in setupClass resulted in skipping the rest of the setup, so the value is null. If so, then it's likely a trivial "if not null" check, so I'll go ahead and continue reviewing. Thanks again for updating
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
