arpadboda commented on a change in pull request #689: MINIFICPP-1095 change CapturePacket header guard to be unique URL: https://github.com/apache/nifi-minifi-cpp/pull/689#discussion_r354275395
########## File path: extensions/pcap/CapturePacket.h ########## @@ -16,8 +16,8 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -#ifndef __INVOKE_HTTP_H__ -#define __INVOKE_HTTP_H__ +#ifndef EXTENSIONS_CAPTUREPACKET_H +#define EXTENSIONS_CAPTUREPACKET_H Review comment: Nice catch, thanks for that! Please check the style in standard processors. The closing #endif at the end of the file should have a comment to indicate which header guard it closes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
