bahlulh commented on a change in pull request #3920: NIFI-6928 - add
connect/read timeout to RestLookupService
URL: https://github.com/apache/nifi/pull/3920#discussion_r354971935
##########
File path:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java
##########
@@ -199,6 +222,10 @@ public void onEnabled(final ConfigurationContext context)
{
setAuthenticator(builder, context);
+ // Set timeouts
+
builder.connectTimeout((context.getProperty(PROP_CONNECT_TIMEOUT).asTimePeriod(TimeUnit.MILLISECONDS).intValue()),
TimeUnit.MILLISECONDS);
+
builder.readTimeout(context.getProperty(PROP_READ_TIMEOUT).asTimePeriod(TimeUnit.MILLISECONDS).intValue(),
TimeUnit.MILLISECONDS);
Review comment:
Can you add a test for this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
