arpadboda commented on a change in pull request #688: MINIFICPP-1094 - Update xcode images in Travis CI builds URL: https://github.com/apache/nifi-minifi-cpp/pull/688#discussion_r355514350
########## File path: thirdparty/rocksdb/CMakeLists.txt ########## @@ -216,7 +216,7 @@ if(HAVE_THREAD_LOCAL) add_definitions(-DROCKSDB_SUPPORT_THREAD_LOCAL) endif() -option(FAIL_ON_WARNINGS "Treat compile warnings as errors" ON) +option(FAIL_ON_WARNINGS "Treat compile warnings as errors" OFF) Review comment: This is just a quickfix, going to be properly done in scope of: https://github.com/apache/nifi-minifi-cpp/pull/661 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
