bakaid commented on a change in pull request #691: MINIFICPP-1098 - MacOS 
builds should use the built-in homebrew addon …
URL: https://github.com/apache/nifi-minifi-cpp/pull/691#discussion_r355987786
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -138,49 +138,45 @@ matrix:
         - ./bootstrap.sh -e -t && cd build  && cmake -DUSE_SHARED_LIBS=ON .. 
&&  cmake --build . --parallel 4  && sudo make test ARGS="-j4 
--output-on-failure"
     - os: osx
       osx_image: xcode10.3
+      addons:
 
 Review comment:
   According to the 
[documentation](https://docs.travis-ci.com/user/installing-dependencies/#installing-packages-on-macos),
 this won't update the packages, only if specified explicitly. So far we did 
update them. If the packages in the Travis VM snapshot are recent enough this 
should be ok, and we can make builds faster this way, but we should make sure 
of that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to