bakaid commented on a change in pull request #692: MINIFICPP-1099 - Fix Windows MSI build URL: https://github.com/apache/nifi-minifi-cpp/pull/692#discussion_r356193445
########## File path: win_build_vs.bat ########## @@ -23,6 +23,7 @@ set builddir=%1 set skiptests=OFF set cmake_build_type=Release set build_type=Release +set build_platform=Win32 Review comment: When using with vcvarsall.bat, it sets an environment variable which makes msbuild default to x86 as the default platform, not Win32, so we use this to make sure we use the proper Win32 platform. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
