bakaid commented on issue #692: MINIFICPP-1099 - Fix Windows MSI build
URL: https://github.com/apache/nifi-minifi-cpp/pull/692#issuecomment-564613428
 
 
   > I tested. LGTM!
   > It would be good to test minifi.exe (without using installer) on machine 
with old redistributables, (maybe on Windows 7) and verify that it doesn't work 
and then install it and check that it works.
   
   @amarmer Thank you for trying it.
   I have tested it on a Windows 7 instance, and I verified that if I had a 
preinstalled VC 2015 Runtime, our msi really did update the dlls to a newer 
version.
   I couldn't try it from a not working state, as the older DLLs are still 
binary compatible, even if it is unsupported to use an older version than our 
code was built with - this is the reason we have been able to run on Windows at 
all so far.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to