[
https://issues.apache.org/jira/browse/MINIFICPP-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994543#comment-16994543
]
Marc Parisi edited comment on MINIFICPP-1100 at 12/12/19 11:20 AM:
-------------------------------------------------------------------
"The size of the build isn't moot, we can go below 16 MB, our current Win
executable is around 8MB, so I would prefer to avoid boost as much as I can. "
Yep, [~aboda] I assume you're referring to binaries that are not fully
statically linked or those done on OSX?
My initial comment on the ticket was about taking only base64 headers from
boost repos, but also taking an objective look at what cost we'd incur by
including boost related to what we build for Apache releases and the "smaller
non statically linked builds" I'd prefer the latter but I think the former is
more readily acceptable. The github repo I linked has more activity and stars
than our project and is partially used by boost so that's an excellent
alternative.
was (Author: phrocker):
"The size of the build isn't moot, we can go below 16 MB, our current Win
executable is around 8MB, so I would prefer to avoid boost as much as I can. "
Yep, [~aboda] I assume you're referring to binaries that are not fully
statically linked or those done on OSX?
My initial comment on the ticket was about taking only base64 headers from
boost repos, but also taking an objective look at what cost we'd incur by
including boost related to what we build for Apache releases and the "smaller
non statically linked builds" I'd prefer the latter but I think the former is
more readily acceptable. The github repo I linked has more activity and stars
than our project and is partially used by boost so that's an excellent
alternative.
> Replace custom base 64 encoding with Boost or alternative.
> -----------------------------------------------------------
>
> Key: MINIFICPP-1100
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1100
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Marc Parisi
> Priority: Blocker
> Fix For: 0.7.0
>
>
> Per the discussion of MINIFICPP-1026, I think using and referencing boost lib
> for not only this component but also others is ideal.
> "Yep. I was 1. My gut suggestion was to use boost's base 64 since it's
> relatively isolated. If you look at the boost variant they mention portions
> come from this repo ( [https://github.com/ReneNyffenegger/cpp-base64])"
>
> Since we have increased the build with static libs we might as well begin
> explore simply using boost directly. The size of the build is moot at that
> point. We should have rationale why custom libs are added to our core when
> alternatives exist that are more widely used.
> Build time, if we only reference portions of boost, should not increase
> dramatically.
>
> I believe that this should occur despite the inertia of the expedient merge
> and should function as a augmentation of the tests and replacement of the
> custom code in StringUtils.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
