bakaid commented on a change in pull request #697: MINIFICPP-1104 - SSL docker
tests for PublishKafka
URL: https://github.com/apache/nifi-minifi-cpp/pull/697#discussion_r358306221
##########
File path: docker/test/integration/minifi/test/__init__.py
##########
@@ -55,6 +55,9 @@ def __init__(self, output_validator):
logging.info('Creating tmp test resource dir: %s',
self.tmp_test_resources_dir)
os.makedirs(self.tmp_test_resources_dir)
+ # Add resources
+
shutil.copytree("docker/test/integration/resources/kafka_broker/conf/certs",
self.tmp_test_resources_dir + "/certs")
Review comment:
Since `make docker-verify` is, AFAIK, the standard way to run the docker
tests, that should at least work, but generally the thing should work without
depending on the current working directory (or, at least, only depend on it
being the build directory). Keep in mind that it is completely supported to
have out-of-tree builds, meaning that the build directory is not the
subdirectory of the source directory, but a completely separate one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
