mattyb149 commented on a change in pull request #3763: NIFI-6684 Add more
property to Hive3ConnectionPool
URL: https://github.com/apache/nifi/pull/3763#discussion_r358372195
##########
File path:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/dbcp/hive/Hive3ConnectionPool.java
##########
@@ -178,6 +278,12 @@ protected void init(final
ControllerServiceInitializationContext context) {
props.add(MAX_WAIT_TIME);
props.add(MAX_TOTAL_CONNECTIONS);
props.add(VALIDATION_QUERY);
+ props.add(MIN_IDLE);
Review comment:
These REALLY should have had some unit tests associated with them,
especially with the use of Expression Language. None of them appear to actually
have EL evaluated, so none of them work with EL. I'll write up a separate Jira
for this since NIFI-6684 went into a release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
