mattyb149 commented on a change in pull request #3133: NIFI-5790: Exposes 6
commons-dbcp options in DBCPConnectionPool
URL: https://github.com/apache/nifi/pull/3133#discussion_r358584947
##########
File path:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
##########
@@ -221,7 +326,13 @@ public void onConfigured(final ConfigurationContext
context) throws Initializati
final String passw =
context.getProperty(DB_PASSWORD).evaluateAttributeExpressions().getValue();
final Integer maxTotal =
context.getProperty(MAX_TOTAL_CONNECTIONS).asInteger();
final String validationQuery =
context.getProperty(VALIDATION_QUERY).evaluateAttributeExpressions().getValue();
- final Long maxWaitMillis =
"-1".equals(context.getProperty(MAX_WAIT_TIME).getValue()) ? -1 :
context.getProperty(MAX_WAIT_TIME).asTimePeriod(TimeUnit.MILLISECONDS);
+ final Long maxWaitMillis =
extractMillisWithInfinite(context.getProperty(MAX_WAIT_TIME));
+ final Integer minIdle = context.getProperty(MIN_IDLE).asInteger();
Review comment:
Related to #3937 , these new properties should have EL evaluated on them as
the doc suggests. I wrote https://issues.apache.org/jira/browse/NIFI-6954 to
add the calls to `evaluateAttributeExpressions()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
