MikeThomsen commented on a change in pull request #3926: NIFI-818: Initial implementation of Apache Accumulo on NiFi URL: https://github.com/apache/nifi/pull/3926#discussion_r361880659
########## File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-processors/src/main/java/org/apache/nifi/accumulo/data/AccumuloRecordConfiguration.java ########## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.accumulo.data; + +/** + * Encapsulates configuring the session with some required parameters. + * + * Justification: Generally not a fan of this fluent API to configure other objects, but there is a lot encapsulated here + * so it helps minimize what we pass between the current set of classes and the upcoming features. + */ +public class AccumuloRecordConfiguration { + private String tableName; + private String rowFieldName; + private String columnFamily; + private String columnFamilyField; + private String timestampField; + private String fieldDelimiter; + private boolean encodeFieldDelimiter; + private boolean qualifierInKey; + private boolean deleteKeys; + + + protected AccumuloRecordConfiguration(final String tableName, final String rowFieldName, final String columnFamily, + final String columnFamilyField, + final String timestampField, final String fieldDelimiter, + final boolean encodeFieldDelimiter, + final boolean qualifierInKey, final boolean deleteKeys) { + this.tableName=tableName; Review comment: Style quibble: should be spaces before and after the `=` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
