mattyb149 commented on a change in pull request #3953: NIFI-5901 Added
JSON/JSONB support to PutDatabaseRecord
URL: https://github.com/apache/nifi/pull/3953#discussion_r364540127
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##########
@@ -252,6 +258,16 @@
.defaultValue("false")
.build();
+ static final PropertyDescriptor MAP_RECORD_TO_JSON = new
PropertyDescriptor.Builder()
+ .name("put-db-record-map-record-to-json")
+ .displayName("Map \"record\" types to JSON")
Review comment:
I don't see where MapRecord converts Record to JSON, I thought you were
using Jackson's ObjectMapper for that? For XML I'm leery of JAXB as I guess
that has Java 9+ and/or classpath issues, but I wonder if XStream is an option.
Also I don't know if external systems take YAML these days but the idea was to
offer the capability to support various structured data formats. If everything
but JSON is a non-starter then I'm fine with leaving it a boolean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
