turcsanyip commented on a change in pull request #3966: NIFI-6992 - Add "Batch
Size" property to GetHDFSFileInfo processor
URL: https://github.com/apache/nifi/pull/3966#discussion_r365192302
##########
File path:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/TestGetHDFSFileInfo.java
##########
@@ -76,6 +76,59 @@ public void setup() throws InitializationException {
runner.setProperty(GetHDFSFileInfo.HADOOP_CONFIGURATION_RESOURCES,
"src/test/resources/core-site.xml");
}
+ @Test
+ public void
testInvalidBatchSizeWhenDestinationAndGroupingDoesntAllowBatchSize() throws
Exception {
+ Arrays.asList("1", "2", "100").forEach(
+ validBatchSize -> {
+ testValidateBatchSize(GetHDFSFileInfo.DESTINATION_ATTRIBUTES,
GetHDFSFileInfo.GROUP_ALL, validBatchSize, false);
+ testValidateBatchSize(GetHDFSFileInfo.DESTINATION_ATTRIBUTES,
GetHDFSFileInfo.GROUP_PARENT_DIR, validBatchSize, false);
+ testValidateBatchSize(GetHDFSFileInfo.DESTINATION_ATTRIBUTES,
GetHDFSFileInfo.GROUP_NONE, validBatchSize, false);
+ testValidateBatchSize(GetHDFSFileInfo.DESTINATION_CONTENT,
GetHDFSFileInfo.GROUP_ALL, validBatchSize, false);
+ testValidateBatchSize(GetHDFSFileInfo.DESTINATION_CONTENT,
GetHDFSFileInfo.GROUP_PARENT_DIR, validBatchSize, false);
+ }
+ );
+ }
+
+ @Test
+ public void testValidBatchSize() throws Exception {
+ Arrays.asList("1", "2", "100").forEach(
+ validBatchSize -> {
+ testValidateBatchSize(GetHDFSFileInfo.DESTINATION_CONTENT,
GetHDFSFileInfo.GROUP_NONE, validBatchSize, true);
+ }
+ );
+
+ Arrays.asList("", null).forEach(
+ emptyBatchSize -> {
+ testValidateBatchSize(GetHDFSFileInfo.DESTINATION_ATTRIBUTES,
GetHDFSFileInfo.GROUP_NONE, emptyBatchSize, true);
+ testValidateBatchSize(GetHDFSFileInfo.DESTINATION_ATTRIBUTES,
GetHDFSFileInfo.GROUP_PARENT_DIR, emptyBatchSize, true);
+ testValidateBatchSize(GetHDFSFileInfo.DESTINATION_ATTRIBUTES,
GetHDFSFileInfo.GROUP_ALL, emptyBatchSize, true);
+ testValidateBatchSize(GetHDFSFileInfo.DESTINATION_CONTENT,
GetHDFSFileInfo.GROUP_ALL, emptyBatchSize, true);
+ testValidateBatchSize(GetHDFSFileInfo.DESTINATION_CONTENT,
GetHDFSFileInfo.GROUP_PARENT_DIR, emptyBatchSize, true);
Review comment:
Grouping=NONE + Destination=CONTENT + Batch Size="" / null should also be
added as a valid config.
Grouping=NONE + Destination=CONTENT could also be tested with -1 and 0 as
invalid configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
