gardellajuanpablo commented on a change in pull request #3961: NIFI-6915 Jms
Durable non shared subscription is broken
URL: https://github.com/apache/nifi/pull/3961#discussion_r365609512
##########
File path:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/ConsumeJMS.java
##########
@@ -173,6 +175,23 @@
relationships = Collections.unmodifiableSet(_relationships);
}
+ private static boolean isDurableSubscriber(final ProcessContext context) {
+ final Boolean durableBoolean =
context.getProperty(DURABLE_SUBSCRIBER).evaluateAttributeExpressions().asBoolean();
+ return durableBoolean == null ? false : durableBoolean;
+ }
+
+ private static boolean isShared(final ProcessContext context) {
+ final Boolean sharedBoolean =
context.getProperty(SHARED_SUBSCRIBER).evaluateAttributeExpressions().asBoolean();
+ return sharedBoolean == null ? false : sharedBoolean;
+ }
+
+ @OnScheduled
+ public void onSchedule(ProcessContext context) {
Review comment:
Fixed and added unit tests to verify the behavior. You can check without
this fix, the unit test will miss a message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
