szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366331618
########## File path: libminifi/src/controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.cpp ########## @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace controllers { + +core::Property AbstractAutoPersistingKeyValueStoreService::AlwaysPersist( + core::PropertyBuilder::createProperty("Always Persist")->withDescription("Persist every change instead of persisting it periodically.") + ->isRequired(false)->withDefaultValue<bool>(false)->build()); +core::Property AbstractAutoPersistingKeyValueStoreService::AutoPersistenceInterval( + core::PropertyBuilder::createProperty("Auto Persistence Interval")->withDescription("The interval of the periodic task persisting all values. " + "Only used if Always Persist is false. " + "If set to 0 seconds, auto persistence will be disabled.") Review comment: I don't think alignment starting on col 88 is a good idea. I didn't find any guidelines in the google style guide regarding function call argument alignment, but it suggests alignment of function parameters in a function declaration. I'd generally avoid any kind of horizontal alignment. Rationale: last paragraph of https://kotlinlang.org/docs/reference/coding-conventions.html#horizontal-whitespace > As a general rule, avoid horizontal alignment of any kind. Renaming an identifier to a name with a different length should not affect the formatting of either the declaration or any of the usages. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
