arpadboda commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366394673
########## File path: extensions/standard-processors/controllers/UnorderedMapKeyValueStoreService.h ########## @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifndef __UNORDERED_MAP_KEY_VALUE_STORE_SERVICE_H__ +#define __UNORDERED_MAP_KEY_VALUE_STORE_SERVICE_H__ + +#include "controllers/keyvalue/KeyValueStoreService.h" +#include "core/Core.h" +#include "properties/Configure.h" +#include "core/logging/Logger.h" +#include "core/logging/LoggerConfiguration.h" +#include "core/Resource.h" + +#include <unordered_map> +#include <string> +#include <mutex> +#include <memory> +#include <utility> + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace controllers { + +class UnorderedMapKeyValueStoreService : virtual public KeyValueStoreService { + public: + explicit UnorderedMapKeyValueStoreService(const std::string& name, const std::string& id); + explicit UnorderedMapKeyValueStoreService(const std::string& name, utils::Identifier uuid = utils::Identifier()); + explicit UnorderedMapKeyValueStoreService(const std::string& name, const std::shared_ptr<Configure>& configuration); + + virtual ~UnorderedMapKeyValueStoreService(); + + virtual bool set(const std::string& key, const std::string& value) override; + + virtual bool get(const std::string& key, std::string& value) override; + + virtual bool get(std::unordered_map<std::string, std::string>& kvs) override; + + virtual bool remove(const std::string& key) override; + + virtual bool clear() override; + + virtual bool update(const std::string& key, const std::function<bool(bool /*exists*/, std::string& /*value*/)>& update_func) override; + + protected: + std::unordered_map<std::string, std::string> map_; + std::recursive_mutex mutex_; Review comment: As we are mostly IO sensitive, we can afford the cost of recursive mutex. Your point is fair, but I wish it was the narrowest bottleneck in our code... :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
