mattyb149 commented on a change in pull request #3977: NIFI-7007 Add update
functionality to the PutCassandraRecord processor.
URL: https://github.com/apache/nifi/pull/3977#discussion_r366569391
##########
File path:
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java
##########
@@ -67,6 +75,35 @@
.required(true)
.build();
+ static final PropertyDescriptor STATEMENT_TYPE = new
PropertyDescriptor.Builder()
+ .name("put-cassandra-record-statement-type")
+ .displayName("Statement Type")
+ .description("Specifies the type of CQL Statement to generate.")
+ .required(true)
+ .defaultValue(INSERT_TYPE)
+ .allowableValues(UPDATE_TYPE, INSERT_TYPE)
+ .build();
+
+ static final PropertyDescriptor UPDATE_METHOD = new
PropertyDescriptor.Builder()
+ .name("put-cassandra-record-update-method")
+ .displayName("Update Method")
+ .description("Specifies the method to use to SET the values.")
Review comment:
Do you see other Statement Types being included someday, such as UPSERT,
DELETE, etc.? I ask because I wonder if we need a separate property for Update
Method or if we can include 3 Statement Types (Update Set, Update Increment,
Update Decrement) and only use one property. Then if we add UPSERT, DELETE,
etc. we don't have extra properties that only pertain to one of the Statement
Types.
Either way is fine with me, just trying to design for the future so we don't
run into compatibility or awkward configuration issues (too many properties,
e.g.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
