am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367275409
########## File path: libminifi/src/utils/file/PathUtils.cpp ########## @@ -48,6 +56,35 @@ bool PathUtils::getFileNameAndPath(const std::string &path, std::string &filePat return true; } +std::string PathUtils::getFullPath(const std::string& path) { +#ifdef WIN32 + std::vector<char> buffer(MAX_PATH); + uint32_t len = 0U; + while (true) { + len = GetFullPathNameA(path.c_str(), buffer.size(), buffer.data(), nullptr /*lpFilePart*/); Review comment: nit - - can be used GetFullPathName. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services